Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Esc> or <C-C> should exit visual mode rather than quit #91

Open
tremby opened this issue Aug 30, 2017 · 3 comments
Open

<Esc> or <C-C> should exit visual mode rather than quit #91

tremby opened this issue Aug 30, 2017 · 3 comments
Labels

Comments

@tremby
Copy link
Collaborator

tremby commented Aug 30, 2017

No description provided.

@kimtore
Copy link
Owner

kimtore commented Sep 1, 2017

Are keyboard bindings something that should have context? And regardless of that, should these keyboard shortcuts be hard-coded?

@tremby
Copy link
Collaborator Author

tremby commented Sep 1, 2017

I realize I'm always beating the vim drum here, sorry if it gets old...

In vim bindings do have context. You can set different bindings for the same keystroke depending which mode you're in. map for all modes (I think?) vs imap, nmap, vmap, etc. It's very powerful. I think (so far at least) PMS only has normal and visual modes, right?

I think it'd definitely be good to allow bindings to have mode context. It'd allow this particular feature.

I don't think I have a strong opinion on whether they should be hard-coded. I think perhaps <Esc> and <C-C> should be, since they have meaning beyond the scope of PMS (and beyond the scope of vim).

@tremby
Copy link
Collaborator Author

tremby commented Sep 1, 2017

Then again, maybe being set up that way by default is enough. No strong opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants