OpenGL GetProcAddress function #8589
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines. |
kivy/core/window/_window_sdl2.pyx
Outdated
| @@ -320,6 +321,9 @@ cdef class _WindowSDL2Storage: | |||
| cdef void * p = SDL_GL_GetProcAddress(c_name) | |||
| return <intptr_t>p | |||
|
|
|||
| def reset_gl_context(self): | |||
There was a problem hiding this comment.
Do we need this function?
Why not call the function directly instead of making it like this
There was a problem hiding this comment.
Do you mean the SDL_GL_GetProcAddress function or reset_gl_context?
Anyway SDL_GL_GetProcAddress returns void pointer so there's no point to call it directly because we need to cast it to intptr_t, and about reset_gl_context I don't know how to call it directly because it can't be imported from kivy.graphics.instructions from python
misl6
requested changes
Jan 31, 2024
kivy/core/window/_window_sdl2.pyx
Outdated
| @@ -314,6 +316,14 @@ cdef class _WindowSDL2Storage: | |||
| cdef void set_cursor(self, SDL_Cursor * cursor): | |||
| SDL_SetCursor(cursor) | |||
|
|
|||
| def get_proc_address(self, name): | |||
| cdef char *c_name = name | |||
| cdef void * p = SDL_GL_GetProcAddress(c_name) | |||
There was a problem hiding this comment.
SDL is not necessarily the GL provider for SDL-backed windows
How about exposing it in kivy.graphics.cgl ?
Make reset_gl_context function callable from python kivy#8457
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8457
Maintainer merge checklist
Component: xxxlabel.api-deprecationorapi-breaklabel.release-highlightlabel to be highlighted in release notes.versionadded,versionchangedas needed.