Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

policy-bot should validate policy changes #362

Open
AdamDeHovitz opened this issue Jan 11, 2022 · 0 comments · May be fixed by #448
Open

policy-bot should validate policy changes #362

AdamDeHovitz opened this issue Jan 11, 2022 · 0 comments · May be fixed by #448

Comments

@AdamDeHovitz
Copy link
Contributor

AdamDeHovitz commented Jan 11, 2022 •
edited

Currently the policy-bot check validates if the policy on the target branch is satisfied. In cases where the PR is modifying policy.yml the policy-bot check should also validate that the new policy is valid via <policy-bot url>/api/validate (valid meaning well formatted, not satisfied).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature: Validate incoming policy definition in PR changes palantir/policy-bot
1 participant
@AdamDeHovitz