Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(QDialog): should keep at least 24px padding on minimized on ios #6052

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

mesqueeb
Copy link
Contributor

Explanation

On the browser a minimized QDialog will always have a minimum of 24px padding.
On my iPad mini, the statusbar had a minimum padding for just the status bar, but the bottom had 0 padding. I believe that it should keep that minimum of 24px of padding, just like the browser.
No need to have 0px padding for dialogs on iPads.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@mesqueeb
Copy link
Contributor Author

done
check "explanation" above

@mesqueeb
Copy link
Contributor Author

mesqueeb commented Feb 2, 2020

@rstoenescu see "explanation" at the top of the pr ;)

@rstoenescu
Copy link
Member

Marking for v1.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants