-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement async methods in RedisKVStore #12943
Implement async methods in RedisKVStore #12943
Conversation
|
||
Args: | ||
key (str): key | ||
val (dict): value | ||
collection (str): collection name | ||
|
||
""" | ||
raise NotImplementedError | ||
return self.put(key=key, val=val, collection=collection) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we take the time to actually implement the async method though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fake-async will still block the thread
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@philipchung light bump on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately I don't have time to implement true async methods. I've used this fake async implementation with async ingestion pipeline and have not experienced any major performance degradation for my own use cases.
Ok, I added the actual async methods (wasn't actually too hard) |
Description
Async methods were not implemented in RedisKVStore. This is necessary if RedisKVStore is used as an ingestion cache or docstore in an async ingestion pipeline.
Fixes #10248
Implement async methods.
New Package?
Did I fill in the
tool.llamahub
section in thepyproject.toml
and provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.toml
file of the package I am updating? (Except for thellama-index-core
package)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lint
to appease the lint gods