Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 0.22.0 #1500

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Bump version to 0.22.0 #1500

merged 1 commit into from
Mar 9, 2020

Conversation

chrisduerr
Copy link
Contributor

There are two PRs I'm aware of that should be relatively trivial to get
merged, which would fix some issues. Other than those, I don't think it
makes sense to wait on anything.

While #1459 seems pretty essential to actually make winit run, #1490 is
much less important and can probably be ignored if there aren't any
resources to merge it.

There are two PRs I'm aware of that should be relatively trivial to get
merged, which would fix some issues. Other than those, I don't think it
makes sense to wait on anything.

 - Fix Windows crash: rust-windowing#1459
 - Fix macOS mouse reports: rust-windowing#1490

While rust-windowing#1459 seems pretty essential to actually make winit run, rust-windowing#1490 is
much less important and can probably be ignored if there aren't any
resources to merge it.
@kchibisov
Copy link
Member

I think it should be done when some arcane crashes on Windows should be fixed. So I feel like waiting a bit for #1496.

@Osspial
Copy link
Contributor

Osspial commented Mar 7, 2020

I think we should hold off on #1496 for this particular release, since #1461 addresses the same issues but is a bit more stable at present.

@kchibisov
Copy link
Member

Hm, maybe we should at least take a look at the following PRs before the release

#1501 - Revert of bad fix.
#1483 - Fixes minor API inconsistency.

@chrisduerr
Copy link
Contributor Author

It's not worth waiting even a second for #1483 tbh. If it is merged by the time this is good to go, that's no problem. But this API inconsistency has existed for so long that it really has no urgency at all.

If winit's latest version is usable on all major platforms, then we can talk about fixing things that would be nice to have.

@Osspial Osspial merged commit 7a9c17a into rust-windowing:master Mar 9, 2020
@chrisduerr chrisduerr deleted the v0.22.0 branch March 9, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants