-
-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure two interfaces with the same name do not cause compile errors #1542
base: main
Are you sure you want to change the base?
Conversation
Is there any documentation I should update? Version history or so? |
We are starting to evaluate another release. So will go through these PRs soon. thanks for the contribution. |
Fix unit tests on difference in extra spaces in output.
…o fix/bug-1261
I just added a fix for the unit tests. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1542 +/- ##
==========================================
- Coverage 87.73% 87.72% -0.01%
==========================================
Files 33 33
Lines 2348 2322 -26
Branches 294 289 -5
==========================================
- Hits 2060 2037 -23
+ Misses 208 207 -1
+ Partials 80 78 -2 ☔ View full report in Codecov by Sentry. |
What kind of change does this PR introduce?
Fixes bug #1261.
What is the current behavior?
See bug #1261. In short, source generator fails if there are more than two interfaces with the same name.
What is the new behavior?
Any number of interface with the same name is supported by extending the methodology that supported two interfaces with the same name.
What might this PR break?
Nothing that I expect.
Please check if the PR fulfills these requirements
Other information: