Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(shadow-dom): support root style in shadow dom #2146

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(shadow-dom): support root style in shadow dom #2146

wants to merge 1 commit into from

Conversation

MarvelSQ
Copy link
Member

允许样式在 web-componets 中生效
增加 :host 选择器

https://developer.mozilla.org/zh-CN/docs/Web/CSS/:host

@vercel
Copy link

vercel bot commented Nov 21, 2021

@MarvelSQ is attempting to deploy a commit to the rsuite Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Nov 21, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

rsuite-nextjs – ./docs

🔍 Inspect: https://vercel.com/rsuite/rsuite-nextjs/76VedBWWNZZcePLwEudJuE4KtBgQ
✅ Preview: https://rsuite-nextjs-git-fork-marvelsq-feat-shadow-dom-support-rsuite.vercel.app

rsuite – ./

🔍 Inspect: https://vercel.com/rsuite/rsuite/63GmAWAATma2qMnvRXLgU7AAAcbk
✅ Preview: https://rsuite-git-fork-marvelsq-feat-shadow-dom-support-rsuite.vercel.app

rsuite-v4 – ./docs

🔍 Inspect: https://vercel.com/rsuite/rsuite-v4/4HruAe1W6Bq8qLg6VnT8SQbcM86t
✅ Preview: Canceled

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d95da9c:

Sandbox Source
rsuite-tp-ci Configuration

@vercel vercel bot temporarily deployed to Preview – rsuite-v4 November 22, 2021 04:09 Inactive
simonguo
simonguo requested changes Nov 24, 2021
View reviewed changes
src/styles/color-modes.less
@@ -1,6 +1,7 @@
// Themes

:root,
:host,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

触发了 selector-pseudo-class-allowed-list 校验规则。

src/styles/color-modes.less
 4:1  ✖  Unexpected pseudo-class "host"   selector-pseudo-class-allowed-list

SevenOutman
SevenOutman reviewed Nov 24, 2021
View reviewed changes
Copy link
Member

@SevenOutman SevenOutman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以在 examples 中添加一个在 web component 中使用 rsuite 的例子吗？

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SevenOutman SevenOutman SevenOutman left review comments

@simonguo simonguo simonguo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarvelSQ @simonguo @SevenOutman