Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

biomeTweaker fails to use remove() command [1.19.2] #292

Open
NaomiCatt opened this issue Jan 4, 2023 · 4 comments
Open

biomeTweaker fails to use remove() command [1.19.2] #292

NaomiCatt opened this issue Jan 4, 2023 · 4 comments

Comments

@NaomiCatt
Copy link

NaomiCatt commented Jan 4, 2023

This is my first time writing an issue on Github, sorry if I'm writing this in the wrong place, I've already noticed someone posted the same problem for the 1.18.2 version.

The problem is straightforward, biomeTweaker doesn't recognise the remove() command in my script.
The game itself loads in fine but the biomes are still there.
The latest.log error I get:

[04Jan2023 17:41:47.796] [modloading-worker-0/INFO] [biometweaker/]: Beginning script parsing...
[04Jan2023 17:41:47.802] [modloading-worker-0/ERROR] [SuperScript/]: Failed to find meaning in command remove() @ ScriptContext[scriptName=biomeBlacklist.cfg, lineNumber=2]. Reason: No commands found with that name.
[04Jan2023 17:41:47.806] [modloading-worker-0/INFO] [biometweaker/]: Finished script parsing.

there's no more error mentioned of this throughout the log.
My script biomeBlacklist.cfg inside the scripts folder of the mod's config folder:

biomeBlacklist = forBiomes("terralith:alpha_islands_winter", "terralith:alpha_islands", "terralith:alpine_grove", "terralith:amethyst_canyon", "terralith:amethyst_rainforest", "terralith:ashen_savanna", "terralith:basalt_cliffs", "terralith:caldera", "terralith:cloud_forest", "terralith:desert_spires", "terralith:emerald_peaks", "terralith:fractured_savanna", "terralith:glacial_chasm", "terralith:granite_cliffs", "terralith:gravel_beach", "terralith:haze_mountain", "terralith:ice_marsh", "terralith:lavender_forest", "terralith:lavender_valley", "terralith:mirage_isles", "terralith:moonlight_grove", "terralith:moonlight_valley", "terralith:orchid_swamp", "terralith:red_oasis", "terralith:rocky_mountains", "terralith:rocky_shrubland", "terralith:sakura_grove", "terralith:sakura_valley", "terralith:scarlet_mountains", "terralith:shrubland", "terralith:skylands_spring", "terralith:skylands_summer", "terralith:skylands_winter", "terralith:stony_spires", "terralith:tropical_jungle", "terralith:volcanic_crater", "terralith:volcanic_peaks", "terralith:white_cliffs", "terralith:windswept_spires", "terralith:yosemite_cliffs", "terralith:yosemite_lowlands")
biomeBlacklist.remove()

the biomes inside forBiomes() are all on the first line, followed by the 'biomeBlacklist.remove()' on the second line.
I've also noticed that most of the folders the mod generates in it's config folder are empty, that being the 'carvers' and 'features' folders.
I've also generated the output folder via in-game command, still the same outcome follows.
My guess is that it's due to a certain 'hardcoded' biome in the list that the mod can't remove, but then should'nt an error be thrown and shown in the logs? My only other guess is that I'm missing a file of some kind.

@superckl
Copy link
Owner

superckl commented Jan 5, 2023

The remove command does not exist in 1.18+. You must use a datapack to remove biomes.

The lack of output is indicative that an error occured. I would need to see the log after you run the output command.

@NaomiCatt
Copy link
Author

hmm, I've also tried .registerGenBiomeRep() command to replace the mentioned biomes above, the same outcome follows. I'm guessing this command doesn't exist in 1.18+ either. I'll probably end up making a quick datapack.

@xiodos666
Copy link

i've been dealing with the same thing too and have been looking EVERYWHERE to try and remove biomes or at least replace them. If you have any info on a datapack or where to start it would be amazing, i've been struggling for so long... 😭😭😭

@Dinerell
Copy link

#299 I posted something in that issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants