Initialize Disabled Posthog Instance When API Key is Not Present #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
No changes required. The modifications made in sweepai/utils/event_logger.py are appropriate. Good job on adding the functionality to initialize an empty Posthog instance and log a warning message when POSTHOG_API_KEY is not set. Also, the indentation correction in the code block that handles HIGHLIGHT_API_KEY is appreciated. Keep up the good work!
|
In disabled posthog instance, pass the "mock" string as an project_api_key, pass the host |
bdb5d38
to
53d941c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue of initializing a disabled
posthoginstance when thePOSTHOG_API_KEYis not present.Previously, the
posthoginstance was set toNonewhen thePOSTHOG_API_KEYwas not present. This has been modified so that a disabledposthoginstance is initialized instead.Additionally, a log statement at the warning level has been added to indicate the initialization of the empty
posthoginstance. This will aid in debugging and understanding the state of the application.The changes are made in the
sweepai/utils/event_logger.pyfile.Fixes #236.
To checkout this PR branch, run the following command in your terminal: