Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update product webhook - old data is being sent for channel_listings #9992

Open
6 tasks
g-londhe opened this issue Jun 13, 2022 · 11 comments
Open
6 tasks

update product webhook - old data is being sent for channel_listings #9992

g-londhe opened this issue Jun 13, 2022 · 11 comments
Labels
bug

Comments

@g-londhe
Copy link

g-londhe commented Jun 13, 2022 •
edited

What I'm trying to achieve

Update the product from the saleor dashboard and catch the updated data in the webhook.

Steps to reproduce the problem

  1. Create a product from the dashboard or using graphql API. ( I created from both)
    Following are the steps to create a product.
    Create_product_query,
    Add_product_to_channel_listing,
    Update_product_variant_channel,
    Create_digital_content.

What I expected to happen

update_product should send the updated data while calling the webhook.

Screenshots and logs

System information

Saleor version:

  • dev (current main)
  • [ x ] 3.2
  • 2.11
  • 2.10

Operating system:

  • Windows
  • [ x ] Linux
  • MacOS
  • Other
@g-londhe g-londhe added the bug label Jun 13, 2022
@timuric
Copy link
Member

timuric commented Jun 14, 2022

@g-londhe dashboard is triggering several mutations on save, therefore there should be several webhook calls with different payloads.

@g-londhe
Copy link
Author

@timuric none of those have new data for channel_listings, always values before save are received in web-hook.

@manojLondhe
Copy link
Contributor

+1

Noticed that for channel_listings, always values before save are received in web-hook.
New values are not received.

Need to save twice from admin dashboard to get new data.

@manojLondhe
Copy link
Contributor

Noticed same for media as well.

If I add 2 images in product media from saleor-admin-dashboard, I get 1 in webhook.
Next time in edit, if I add 3 images - in webhook I get 2 images.

Something is definitely weird here.

@timuric
Copy link
Member

timuric commented Jun 24, 2022

Thanks for reporting, we will dive in next week.

@manojLondhe
Copy link
Contributor

@timuric any idea in which release this will be fixed?

1 similar comment
@manojLondhe
Copy link
Contributor

@timuric any idea in which release this will be fixed?

@timuric
Copy link
Member

timuric commented Jul 20, 2022

@patrys was this issue resolved?

@patrys
Copy link
Member

patrys commented Jul 21, 2022

I am confirming this with the QA team.

@manojLondhe
Copy link
Contributor

This majorly affects everything built using external apps which heavily rely on webhooks.

@timuric
Copy link
Member

timuric commented Jul 22, 2022

@manojLondhe we were able to reproduce it and add it as a high priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@patrys @manojLondhe @timuric @g-londhe