Request a layout when a paragraph's overflow mode is changed (flutter…

…#9485) A change in overflow mode requires calculation of the text size and resetting the overflow shader
taylorren · Apr 20, 2017 · da7867b · da7867b
1 parent a657428
commit da7867b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/packages/flutter/lib/src/rendering/paragraph.dart b/packages/flutter/lib/src/rendering/paragraph.dart
@@ -98,7 +98,7 @@ class RenderParagraph extends RenderBox {
       return;
     _overflow = value;
     _textPainter.ellipsis = value == TextOverflow.ellipsis ? _kEllipsis : null;
-    markNeedsPaint();
+    markNeedsLayout();
   }
 
   /// The number of font pixels for each logical pixel.

diff --git a/packages/flutter/test/rendering/paragraph_test.dart b/packages/flutter/test/rendering/paragraph_test.dart
@@ -140,6 +140,10 @@ void main() {
     relayoutWith(maxLines: 3, softWrap: true, overflow: TextOverflow.fade);
     expect(paragraph.debugHasOverflowShader, isTrue);
 
+    // Change back to ellipsis and check that the fade shader is cleared.
+    relayoutWith(maxLines: 3, softWrap: true, overflow: TextOverflow.ellipsis);
+    expect(paragraph.debugHasOverflowShader, isFalse);
+
     relayoutWith(maxLines: 100, softWrap: true, overflow: TextOverflow.fade);
     expect(paragraph.debugHasOverflowShader, isFalse);
   });