Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icon): update visual studio icon(s) #3227

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

hiteacheryouare
Copy link

Fixes #3170

Changes proposed:

  • Add
  • Fix

Still needs to be saved as optimized SVG

@hiteacheryouare hiteacheryouare changed the title feat: update visual studio icon(s) feat(icon): update visual studio icon(s) Jan 30, 2023
@robertohuertasm robertohuertasm added this to the Next milestone Apr 10, 2023
@robertohuertasm
Copy link
Member

Not sure why but the icons are huge! csproj was about 1.7kb and new version is about 13kb. We're aiming for 2kb top.

@robertohuertasm
Copy link
Member

Even with the inkscape optimization the icon size is greater than 8kb. We'll need to work on these icons before merging this.

@robertohuertasm robertohuertasm added the needs icon rework The icon doesn't follow the guidelines label Apr 10, 2023
@robertohuertasm robertohuertasm modified the milestones: Next, Backlog Apr 10, 2023
@robertohuertasm
Copy link
Member

We already have a vs icon in the vs folder svg that we could reuse for this one.

@hiteacheryouare
Copy link
Author

Is it the updated one?

@jerone
Copy link

jerone commented Jun 20, 2023

Also svgo won't get it down to anything close to 2kb (csproj: 13.92k → 6.19k = 44.46%).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
file icons needs icon rework The icon doesn't follow the guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon Request]: Visual Studio updated logo
3 participants