Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(icon): add icons for libreoffice #3400

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat(icon): add icons for libreoffice #3400

wants to merge 4 commits into from

Conversation

remcohaszing
Copy link
Contributor

The LibreOffice icons are applied to each matching open document file extension.

Fixes #2558
Fixes #2559
Fixes #2560

Changes proposed:

  • Add
  • Delete
  • Fix
  • Prepare

@remcohaszing
feat(icon): add icons for libreoffice
ddbbeb4 
The LibreOffice icons are applied to each matching open document file
extension.

Closes vscode-icons#2558
Closes vscode-icons#2559
Closes vscode-icons#2560
@robertohuertasm robertohuertasm added this to the Next milestone Jan 13, 2024
robertohuertasm
robertohuertasm requested changes Jan 14, 2024
View reviewed changes
Copy link
Member

@robertohuertasm robertohuertasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some icons are huge (up to 10Kb). We should try to minimize them somehow. Our guidelines speak about 2Kb. We can relax that sometimes, especially if the icon is going to be applied to a few files in a code base (a configuration file, for example).

@robertohuertasm robertohuertasm modified the milestones: 12.7.0, Backlog Jan 14, 2024
@robertohuertasm robertohuertasm added the needs icon rework The icon doesn't follow the guidelines label Jan 14, 2024
@remcohaszing
Copy link
Contributor Author

There are quite a lot of subtle gradients. Replacing those with solid colors should make quite a difference.

I can't do this right now though. It's going to be somewhere next week.

@robertohuertasm
Copy link
Member

Ok @remcohaszing! There's no rush. Take the time it needs. This PR is fantastic!

@remcohaszing
Minify LibreOffice icons
2c5716f 
Reducing subtle gradients and merging paths allowed to significantly
reduce file size, while maintaining recognizable, especially on a small
scale.
@remcohaszing
Copy link
Contributor Author

I managed to significantly reduce the original file sizes, but some still exceed the guidelines for the size limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertohuertasm robertohuertasm robertohuertasm requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
needs icon rework The icon doesn't follow the guidelines
Projects
None yet
Milestone
Backlog
2 participants
@remcohaszing @robertohuertasm