Adding ssl keys log using SSLKEYLOGFILE env var for SSLContext (yt-dlp/yt-dlp#9531) #9543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coletdjnz
added
enhancement
Grub4K
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
This should def be supported
When
keylog_filenameis supported and the environment variableSSLKEYLOGFILEis set,create_default_context()enables key logging.
as per the ssl docs
bashonly
reviewed
Mar 27, 2024
… and sorted the imports
Grub4K
approved these changes
Apr 7, 2024
bashonly
approved these changes
Apr 7, 2024
|
@coletdjnz Do I need to do something else, or just wait? |
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Authored by: luiso1979
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Added the possibility to log the ssl keys of secure communications by specifying the standard env variable SSLKEYLOGFILE for request handles using the SSLContext.
Fixes #9531
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?