Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some models in the service-worker-mocks package have incorrect class inheritance #127

Open
DCtheTall opened this issue Nov 21, 2019 · 0 comments
Open

Some models in the service-worker-mocks package have incorrect class inheritance #127

DCtheTall opened this issue Nov 21, 2019 · 0 comments

Comments

@DCtheTall
Copy link

DCtheTall commented Nov 21, 2019 •
edited

According to the spec, Client is not a child of the EventTarget class.

Also the Notification class is a child of the EventTarget class.

FWIW TypeScript agrees with what is in the spec. I'd be happy to supply a PR with a fix, but first, do you guys have open source contributors sign a CLA?
@DCtheTall DCtheTall changed the title Some models in the service-worker-mocks package do not have incorrect class inheritance Some models in the service-worker-mocks package have incorrect class inheritance Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DCtheTall