Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manifest: update quicklogic HAL #72649

Merged
merged 1 commit into from
May 13, 2024
Merged

manifest: update quicklogic HAL #72649

merged 1 commit into from
May 13, 2024

Conversation

JordanYates
Copy link
Collaborator

Update quicklogic HAL to fix compilation errors when C++ support is enabled.

Fixes #72604.

@zephyrbot
Copy link
Collaborator

zephyrbot commented May 13, 2024 •
edited

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_quicklogic zephyrproject-rtos/hal_quicklogic@b3a66fe zephyrproject-rtos/hal_quicklogic@bad8944 (master) zephyrproject-rtos/hal_quicklogic@b3a66fe6..bad89444

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_quicklogic DNM This PR should not be merged (Do Not Merge) labels May 13, 2024
@JordanYates JordanYates added Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc. Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. labels May 13, 2024
@henrikbrixandersen
Copy link
Member

@JordanYates Please update the manifest SHA.

@JordanYates
manifest: update quicklogic HAL
79c47fa 
Update quicklogic HAL to fix compilation errors when C++ support is
enabled.

Fixes zephyrproject-rtos#72604.

Signed-off-by: Jordan Yates <jordan@embeint.com>
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label May 13, 2024
@JordanYates
Copy link
Collaborator Author

@JordanYates Please update the manifest SHA.

Done

@henrikbrixandersen henrikbrixandersen requested a review from a team May 13, 2024 08:40
@carlescufi carlescufi merged commit 4c4f0bc into zephyrproject-rtos:main May 13, 2024
23 of 24 checks passed
@JordanYates JordanYates deleted the 240513_quicklogic_fix branch May 13, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrikbrixandersen henrikbrixandersen henrikbrixandersen approved these changes

@stephanosio stephanosio stephanosio approved these changes

@aescolar aescolar aescolar approved these changes

@ubieda ubieda ubieda approved these changes

@carlescufi carlescufi Awaiting requested review from carlescufi

Assignees
No one assigned
Labels
Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc. manifest manifest-hal_quicklogic Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HAL: quicklogic includes are broken with C++ support
7 participants
@JordanYates @zephyrbot @henrikbrixandersen @stephanosio @aescolar @ubieda @carlescufi