Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate declaration of update_overlay in api sample base clase #989

Open
SaschaWillems opened this issue Mar 17, 2024 · 1 comment
Open

Duplicate declaration of update_overlay in api sample base clase #989

SaschaWillems opened this issue Mar 17, 2024 · 1 comment
Labels
framework This is relevant to the framework

Comments

@SaschaWillems
Copy link
Collaborator

SaschaWillems commented Mar 17, 2024 •
edited

The api sample base class (based on my samples) always had a function called update_overlay in the protected part of the class:

Vulkan-Samples/framework/api_vulkan_sample.h

Line 357 in 0d0cf9b

void update_overlay(float delta_time);

At some point some PR seems to have introduced a virtual function with the same name in the public part:

Vulkan-Samples/framework/api_vulkan_sample.h

Line 115 in 0d0cf9b

virtual void update_overlay(float delta_time, const std::function<void()> &additional_ui) override;

MSVC is picking this up:

image

It looks like the virtual function was supposed to replace the old one, but the old declaration hasn't been removed.
@SaschaWillems SaschaWillems added the framework This is relevant to the framework label Mar 17, 2024
@SaschaWillems SaschaWillems changed the title Wrong or duplicate declaration of update_overlay in api sample base clase Duplicate declaration of update_overlay in api sample base clase Mar 17, 2024
@SaschaWillems
Copy link
Collaborator Author

Looking at that base class it also seems like a lot of recent changes were made without documentation and that there now are two public section. I'll probably do a clean up pass over the whole base class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
framework This is relevant to the framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SaschaWillems