Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Create a pull request for the Clang Tidy #2492

Open
Panquesito7 opened this issue Jun 23, 2023 · 3 comments
Open

[FEATURE] Create a pull request for the Clang Tidy #2492

Panquesito7 opened this issue Jun 23, 2023 · 3 comments
Assignees
@Panquesito7
Labels
dont-close This issue/pull request shouldn't be closed enhancement New feature or request

Comments

@Panquesito7
Copy link
Member

Detailed description

Currently, all of the Clang Tidy changes are being pushed in forks and appearing in other pull requests. However, these changes are not being pushed to the original repository due to the main branch being protected. This can be fixed by creating a pull request (running the action only on this repository) and then the maintainers merging the PR to reflect the changes.

Context

This will make it better for both PR creators and reviewers.

  • PR creators won't have unwanted changes in their PRs.
  • Reviewers won't be confused about other changes in PRs.
  • All changes will be pushed to the original repository, and all missed things will be fixed.

Possible implementation

Create a pull request instead of committing directly.

Additional information

We could also make the check fail if the user has missed anything and let the user fix the errors themselves.
It depends on what you like most. Having a PR created makes it easier and faster. Having the user fix the errors themselves helps them learn.

Let me know your thoughts.
@Panquesito7 Panquesito7 added the enhancement New feature or request label Jun 23, 2023
@realstealthninja
Copy link
Collaborator

this seems like a good idea

@Panquesito7 Panquesito7 self-assigned this Jul 4, 2023
This was referenced Jul 5, 2023
Merged
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Aug 4, 2023
@github-actions
Copy link
Contributor

Please ping one of the maintainers once you add more information and updates here. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions!

@realstealthninja realstealthninja added dont-close This issue/pull request shouldn't be closed and removed stale Author has not responded to the comments for over 2 weeks labels Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Panquesito7 Panquesito7

Labels
dont-close This issue/pull request shouldn't be closed enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: run clang-tidy changes on a PR Panquesito7/C-Plus-Plus
2 participants
@Panquesito7 @realstealthninja