Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding implementation of queue by a binary file #2677

Closed
wants to merge 5 commits into from
Closed

feat: adding implementation of queue by a binary file #2677

wants to merge 5 commits into from

Conversation

chavi362
Copy link

@chavi362 chavi362 commented Jan 23, 2024 •
edited

Description of Change

A special implantation of queue: circular queue by a binary file

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@chavi362
Copy link
Author

Thank you so much for reviewing my PR!

@chavi362
Copy link
Author

@Panquesito7 @realstealthninja can you please review my PR?
Thank you so much!!!!

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Feb 24, 2024
@chavi362
Copy link
Author

@pallavichugh @realstealthninja how are you?
Can you please review my PR?
I think that this is really interesting implementation of queue and can help many C++ learners to understand binary files better.
Thank
Best regards,
Chavi

@github-actions github-actions bot removed the stale Author has not responded to the comments for over 2 weeks label Feb 25, 2024
realstealthninja
realstealthninja approved these changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for contributing! ❤️ please consider these suggestions!

data_structures/circular_queue_using_binaric_file.cpp Outdated Show resolved Hide resolved
data_structures/circular_queue_using_binaric_file.cpp Outdated Show resolved Hide resolved
data_structures/circular_queue_using_binaric_file.cpp Outdated Show resolved Hide resolved
data_structures/circular_queue_using_binaric_file.cpp
Comment on lines +16 to +18
#include <fstream>
#include <iostream>
#include <string>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should document headers as well

#include <header> /// For <reason>

data_structures/circular_queue_using_binaric_file.cpp Outdated Show resolved Hide resolved
chavi362 and others added 4 commits March 18, 2024 12:37
@chavi362 @realstealthninja
Update data_structures/circular_queue_using_binaric_file.cpp
4986761 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@chavi362 @realstealthninja
Update data_structures/circular_queue_using_binaric_file.cpp
3711237 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@chavi362 @realstealthninja
Delete unnecessary line data_structures/circular_queue_using_binaric_…
c7184c9 
…file.cpp

Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@chavi362 @realstealthninja
Update data_structures/circular_queue_using_binaric_file.cpp
484f432 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Apr 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions!

@github-actions github-actions bot closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realstealthninja realstealthninja realstealthninja requested changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7 Panquesito7 is a code owner

Assignees
No one assigned
Labels
stale Author has not responded to the comments for over 2 weeks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chavi362 @realstealthninja