Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding negative binary base conversion algorithms #11213

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

adding negative binary base conversion algorithms #11213

wants to merge 5 commits into from

Conversation

meg-1
Copy link
Contributor

@meg-1 meg-1 commented Dec 13, 2023

Describe your change:

Adding two negative binary base conversion algorithms:

  • decimal to negative binary base conversion
  • negative binary base to decimal conversion

more about negative binary base: link

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Dec 13, 2023
imSanko
imSanko suggested changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@imSanko imSanko left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess you can't be add multiple Algos in a single PR.

@meg-1
Copy link
Contributor Author

meg-1 commented Dec 15, 2023

Two commits can't be addressed in one PR.

Hi! Thank you for your feedback.

Did you mean that two different files cannot be addressed in one PR? If so, then, the reason I put these two files in one PR is for time efficiency (for reviewers to not check both files in different PR's), and convenience, due to the fact that they are directly related.

What are your thoughts about that? Would you recommend I separate them, considering the above information, or keep them like they are?

@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Dec 15, 2023
imSanko
imSanko reviewed Dec 18, 2023
View reviewed changes
Copy link
Contributor

@imSanko imSanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check out Contribution.md while like the maintainers can help you know better in that, but having fixing or adding more than also you can do 2 PR at a time rather adding it into a single one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imSanko imSanko imSanko requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@meg-1 @imSanko