Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wiki has been updated #11226

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

wiki has been updated #11226

wants to merge 1 commit into from

Conversation

Siddharth1605
Copy link

Describe your change:

• Edited the misformatted/linked wiki entry in the Python sorting algorithms page
• Modified the markdown to include the correct formatting and links
• Ensured the changes are saved and visible on the wiki page

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • Fixes Issue Misformatted/linked wiki entry in python sorting #11225

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Jan 2, 2024
@MarlieChiller
Copy link

Fixed the failing doctest test here #11225

I havent taken the time to fully understand that code but given its an issue with years and we have just started 2024, this could be indicative of a deeper issue in this code 🤔

cclauss
cclauss reviewed Jan 12, 2024
View reviewed changes
Python.wiki/Sorting-Algorithms.md
Comment on lines +88 to +90
- Worst-case performance O(n^2)
- Best-case performance O(n)
- Average case performance O(n^2)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it true that Average case == Worst case?!?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Siddharth1605 @MarlieChiller @cclauss