Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doubly_linked_list.py #11277

Closed
wants to merge 1 commit into from

Conversation

GeorgeSkaria
Copy link

*Encapsulated the Node class inside the DoublyLinkedList class
to keep it private and unaccessible from outside.
*Added a size attribute to the DoublyLinkedList class to keep
track of the number of elements in the list. This avoids iterating
over the list every time to calculate its length.
*Added proper error handling in the insert_at_nth and delete_at_nth methods to raise an IndexError when the index is out of range.

Describe your change:

  • Add an algorithm?
  • [✔️ ] Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • [✔️ ] I have read CONTRIBUTING.md.
  • [✔️ ] This pull request is all my own work -- I have not plagiarized.
  • [✔️ ] I know that pull requests will not be merged if they fail the automated tests.
  • [✔️ ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • [ ✔️] All functions and variable names follow Python naming conventions.
  • [✔️ ] All function parameters and return values are annotated with Python type hints.
  • [✔️ ] All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

*Encapsulated the Node class inside the DoublyLinkedList class 
  to  keep it private and unaccessible from outside.
*Added a size attribute to the DoublyLinkedList class to keep 
 track of the number of elements in the list. This avoids iterating 
 over the list every time to calculate its length.
*Added proper error handling in the insert_at_nth and delete_at_nth  methods to raise an IndexError when the index is out of range.
Copy link
Contributor

@imSanko imSanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You just to fix this!

 ruff --output-format=github .
  shell: /usr/bin/bash -e {0}

Error: data_structures/linked_list/doubly_linked_list.py:111:9: PT015 Assertion always fails, replace with pytest.fail()

@cclauss
Copy link
Member

cclauss commented Apr 2, 2024

Removing doctests is a bad idea.

@cclauss cclauss closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants