Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated topological_sort.py #11290

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Updated topological_sort.py #11290

wants to merge 26 commits into from

Conversation

ShengLiuDev
Copy link

Describe your change:

Contributes to #9943

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

ShengLiuDev and others added 25 commits February 11, 2024 19:08
@ShengLiuDev
Update topological_sort.py
9b7e9e1 
Added 10 test cases
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
fe22fb2 
for more information, see https://pre-commit.ci
@ShengLiuDev
Update topological_sort.py
ad74538 
changed camel case to snake case for testCases
@ShengLiuDev
Merge branch 'master' of https://github.com/ShengLiuDev/TheAlgorithms…
2d1622f 
…-Repo
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
0a8383b 
for more information, see https://pre-commit.ci
@ShengLiuDev
Update topological_sort.py
fecee82 
fixed camel casing
@ShengLiuDev
Merge branch 'master' of https://github.com/ShengLiuDev/TheAlgorithms…
047ddd2 
…-Repo
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
029c12f 
for more information, see https://pre-commit.ci
@ShengLiuDev
Fixed Camel Casing
96232dd 
"Value of type "Collection[str]" is not indexable" potential error fix
@ShengLiuDev
Merge branch 'master' of https://github.com/ShengLiuDev/TheAlgorithms…
aace5a0 
…-Repo
@ShengLiuDev
Fixed capitalization
ed0e152 
Dict, List, and Any to lowercase
@ShengLiuDev
Added as keyword
b3e467c 
added as keyword for list, any, and dict
@ShengLiuDev
got rid of import
81bbdd3 
deleted line 2 import as they were deprecated
@ShengLiuDev
Any import
c5fc2a1 
imported any
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
d2eafae 
for more information, see https://pre-commit.ci
@ShengLiuDev
removed any
ae7ae96 
added list in place of any
@ShengLiuDev
Merge branch 'master' of https://github.com/ShengLiuDev/TheAlgorithms…
05eb625 
…-Repo
@ShengLiuDev
rewrote to list
78af49e 
list
@ShengLiuDev
Update topological_sort.py
505e448 
renamed topological_sort to topological_sort_util as a helper function to topological_sort
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
fae8f10 
for more information, see https://pre-commit.ci
@ShengLiuDev
updated line length
d8a8dbb 
made line length less than 88 for doctests
@ShengLiuDev
Merge branch 'master' of https://github.com/ShengLiuDev/TheAlgorithms…
de11626 
…-Repo
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
60ac77c 
for more information, see https://pre-commit.ci
@ShengLiuDev
changed sort and visited types
1fad900 
added sort: list[str] = [] and did the same for visited
@ShengLiuDev
Merge branch 'master' of https://github.com/ShengLiuDev/TheAlgorithms…
eaaa7ca 
…-Repo
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Feb 12, 2024
@ShengLiuDev
Copy link
Author

added a helper function to help with the doctests. Also added a user input for all other inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imSanko imSanko imSanko approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ShengLiuDev @imSanko