Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ruff NPY002 rule #11336

Merged
merged 1 commit into from Apr 1, 2024
Merged

Enable ruff NPY002 rule #11336

merged 1 commit into from Apr 1, 2024

Conversation

MaximSmolskiy
Copy link
Contributor

Describe your change:

Enable ruff NPY002 rule

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@cclauss cclauss merged commit f8a9489 into TheAlgorithms:master Apr 1, 2024
3 checks passed
@MaximSmolskiy MaximSmolskiy deleted the enable-ruff-NPY002-rule branch April 1, 2024 19:42
WahomeKezia
WahomeKezia reviewed Apr 1, 2024
View reviewed changes
Copy link

@WahomeKezia WahomeKezia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use np.random.default_rng() for random number generation in the code update is really cool !

**Suggestions **
Ensure that the test case adequately covers the behavior of the conjugate gradient solver under different scenarios.
Consider adding assertions or checks to validate the correctness of the solver's output.

linear_algebra/src/conjugate_gradient.py
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use np.random.default_rng() for random number generation in the code update is really cool !

**Suggestions **
Ensure that the test case adequately covers the behavior of the conjugate gradient solver under different scenarios.
Consider adding assertions or checks to validate the correctness of the solver's output.

@cclauss
Copy link
Member

cclauss commented Apr 1, 2024

Pull requests accepted. Please go ahead and add appropriate tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WahomeKezia WahomeKezia WahomeKezia left review comments

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MaximSmolskiy @cclauss @WahomeKezia