Create fibonacci_heap.py #9321
Create fibonacci_heap.py #9321
Conversation
Added new heap data structure for Python.
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| self.next = self | ||
|
|
||
| class FibonacciHeap: | ||
| def __init__(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
| self.min_node = None | ||
| self.num_nodes = 0 | ||
|
|
||
| def insert(self, key): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function insert
Please provide return type hint for the function: insert. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: key
| # Increment the number of nodes in the heap | ||
| self.num_nodes += 1 | ||
|
|
||
| def _link(self, root1, root2): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function _link
Please provide return type hint for the function: _link. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: root1
Please provide type hint for the parameter: root2
| root1.degree += 1 | ||
| root2.marked = False | ||
|
|
||
| def _consolidate(self): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function _consolidate
Please provide return type hint for the function: _consolidate. If the function does not return a value, please provide the type hint as: def function() -> None:
| if self.min_node is None or node.key < self.min_node.key: | ||
| self.min_node = node | ||
|
|
||
| def extract_min(self): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function extract_min
Please provide return type hint for the function: extract_min. If the function does not return a value, please provide the type hint as: def function() -> None:
for more information, see https://pre-commit.ci
Added new heap data structure for Python.
Describe your change:
Checklist: