Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample database main #9152

Merged
merged 27 commits into from Apr 25, 2024
Merged

Sample database main #9152

merged 27 commits into from Apr 25, 2024

Conversation

kriks7iitk
Copy link
Collaborator

  1. Added sample database functionality in CE
  2. Changed delete icon for sample datasource list
  3. Changed empty state for editor container
  4. Added sample application template using sample data

@CLAassistant
Copy link

CLAassistant commented Mar 21, 2024 •
edited

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ Kritagya
❌ kriks7raptor

Kritagya seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions GitHub Actions
Copy link

Deployment: https://tooljet-pr-9152.onrender.com
Dashboard: https://dashboard.render.com/web/srv-cnui238cmk4c73fepdp0

@adishM98 adishM98 added the run-ci CI is run only when this label is added label Mar 22, 2024
@nechalmaggon nechalmaggon added create-review-app and removed run-ci CI is run only when this label is added suspend-review-app labels Mar 25, 2024
@github-actions GitHub Actions
Copy link

Deployment: https://tooljet-pr-9152.onrender.com
Dashboard: https://dashboard.render.com/web/null

@nechalmaggon nechalmaggon added the run-ci CI is run only when this label is added label Mar 25, 2024
@github-actions GitHub Actions
Copy link

Deployment: https://tooljet-pr-9152.onrender.com
Dashboard: https://dashboard.render.com/web/null

gsmithun4
gsmithun4 requested changes Apr 17, 2024
View reviewed changes
frontend/src/Editor/DataSourceManager/dataSourceManager.theme.scss
@@ -0,0 +1,67 @@
@import '../../_styles/colors.scss';

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow lint rules

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SCSS doesn't take short path notation from config file. So I think this cant change

@amanregu amanregu mentioned this pull request Apr 19, 2024
Merged
gsmithun4
gsmithun4 previously approved these changes Apr 25, 2024
View reviewed changes
@gsmithun4 gsmithun4 changed the base branch from main to release/platformv17.0 April 25, 2024 12:31
@gsmithun4 gsmithun4 dismissed their stale review April 25, 2024 12:31

The base branch was changed.

@gsmithun4 gsmithun4 added the run-ci CI is run only when this label is added label Apr 25, 2024
@gsmithun4 gsmithun4 merged commit 802e2d9 into release/platformv17.0 Apr 25, 2024
25 of 28 checks passed
@gsmithun4 gsmithun4 deleted the sample-database-main branch April 25, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmithun4 gsmithun4 gsmithun4 approved these changes

Assignees
No one assigned
Labels
run-ci CI is run only when this label is added
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@kriks7iitk @CLAassistant @gsmithun4 @akshaysasidrn @adishM98 @amanregu @nechalmaggon @kriks7raptor