Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cutting and pasting items in an unordered list results in misplaced items #18633

Open
1 task done
stromfeldt opened this issue Oct 15, 2023 · 3 comments
Open
1 task done

Cutting and pasting items in an unordered list results in misplaced items #18633

stromfeldt opened this issue Oct 15, 2023 · 3 comments
Labels
affects:editor Work relating to the Koenig Editor bug [triage] something behaving unexpectedly

Comments

@stromfeldt
Copy link
Contributor

Issue Summary

When trying to cut and then paste an item from an unordered list to a different spot in the list, said item gets placed at the very bottom of the list.

cutting-and-pasting.mov

Steps to Reproduce

  1. Create several items in an unordered list
  2. Cut one of those items
  3. Go to another spot in the middle of the list and paste that item in
  4. See it gets placed at the bottom of the list

Ghost Version

5.68

Node.js Version

Yes

How did you install Ghost?

Ghost(Pro)

Database type

MySQL 5.7

Browser & OS version

Firefox 118.0.2, macOS 13.6

Relevant log / error output

No response

Code of Conduct

  • I agree to be friendly and polite to people in this repository
@github-actions github-actions bot added the needs:triage [triage] this needs to be triaged by the Ghost team label Oct 15, 2023
@daniellockyer daniellockyer added bug [triage] something behaving unexpectedly affects:editor Work relating to the Koenig Editor labels Oct 16, 2023
@github-actions github-actions bot removed the needs:triage [triage] this needs to be triaged by the Ghost team label Oct 16, 2023
@kevinansfield
Copy link
Contributor

Thanks for the report. This is an upstream issue that we're aware of and tracking.

@github-actions GitHub Actions
Copy link
Contributor

Our bot has automatically marked this issue as stale because there has not been any activity here in some time.

The issue will be closed soon if there are no further updates, however we ask that you do not post comments to keep the issue open if you are not actively working on a PR.

We keep the issue list minimal so we can keep focus on the most pressing issues. Closed issues can always be reopened if a new contributor is found. Thank you for understanding 🙂

@github-actions github-actions bot added the stale [triage] Issues that were closed to to lack of traction label Feb 13, 2024
@9larsons
Copy link
Contributor

9larsons commented Feb 15, 2024 •
edited

This seems to persist even after resolving the upstream issue (Lexical had some very major changes to how nodes were inserted). The behaviour upstream isn't perfect as it still injects an empty ListItem node when using Shift+Up selection to not just grab the text... but it at least doesn't dump it at the end of the list like Koenig does, so we've got something to look in to at this point.

Edit: upstream issue facebook/lexical#5124 is what's described here. We still have something in Koenig to update to prevent dumping the pasted content at the end of the list.

@github-actions github-actions bot removed the stale [triage] Issues that were closed to to lack of traction label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects:editor Work relating to the Koenig Editor bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevinansfield @daniellockyer @9larsons @stromfeldt