Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with rendering text in the Signup card #19253

Closed
1 task done
fueko opened this issue Dec 6, 2023 · 4 comments
Closed
1 task done

Issue with rendering text in the Signup card #19253

fueko opened this issue Dec 6, 2023 · 4 comments
Labels
affects:editor Work relating to the Koenig Editor bug [triage] something behaving unexpectedly stale [triage] Issues that were closed to to lack of traction

Comments

@fueko
Copy link
Contributor

fueko commented Dec 6, 2023

Issue Summary

The Signup card does not receive the style with white text (as is the case with the header card) when the card background is set to dark. As a result, this makes the text illegible and inconsistent with contrast principles.

For example Header card:
Zrzut ekranu 2023-12-6 o 10 06 06

Steps to Reproduce

Add a Signup card and set a dark background color.

Ghost Version

5.75.1

Node.js Version

18.12.1

How did you install Ghost?

localhost

Database type

SQLite3

Browser & OS version

All

Relevant log / error output

No response

Code of Conduct

  • I agree to be friendly and polite to people in this repository
@github-actions github-actions bot added the needs:triage [triage] this needs to be triaged by the Ghost team label Dec 6, 2023
@daniellockyer daniellockyer added bug [triage] something behaving unexpectedly affects:editor Work relating to the Koenig Editor labels Dec 7, 2023
@github-actions github-actions bot removed the needs:triage [triage] this needs to be triaged by the Ghost team label Dec 7, 2023
@jaswalsaurabh
Copy link

Hi @daniellockyer can I work on this.

@jaswalsaurabh
Copy link

jaswalsaurabh commented Dec 16, 2023 •
edited

I've found that there is an issue with the conversion of lexical to html. This is the root cause which causing the issueconst useTextColor = !nodeData.backgroundColor === 'transparent';. Its in this dependency @tryghost/kg-default-nodes.

@jaswalsaurabh
Copy link

I've cloned the repo of koenig-editor and found out that this issue is fixed by Steve Larson on Dec 14. But when I check the installed @tryghost/kg-default-nodes module, those changes are not reflected yet in this. But the version are same 1.0.3

@github-actions GitHub Actions
Copy link
Contributor

Our bot has automatically marked this issue as stale because there has not been any activity here in some time.

The issue will be closed soon if there are no further updates, however we ask that you do not post comments to keep the issue open if you are not actively working on a PR.

We keep the issue list minimal so we can keep focus on the most pressing issues. Closed issues can always be reopened if a new contributor is found. Thank you for understanding 🙂

@github-actions github-actions bot added the stale [triage] Issues that were closed to to lack of traction label Apr 15, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects:editor Work relating to the Koenig Editor bug [triage] something behaving unexpectedly stale [triage] Issues that were closed to to lack of traction
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@daniellockyer @fueko @jaswalsaurabh