Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnection of Stripe leaves tiers in limbo. #19293

Open
1 task done
cathysarisky opened this issue Dec 8, 2023 · 0 comments
Open
1 task done

Disconnection of Stripe leaves tiers in limbo. #19293

cathysarisky opened this issue Dec 8, 2023 · 0 comments
Labels
needs:triage [triage] this needs to be triaged by the Ghost team

Comments

@cathysarisky
Copy link
Contributor

cathysarisky commented Dec 8, 2023

Issue Summary

If Stripe is disconnected, tiers are left in an active status, but cannot be archived from the admin panel. They can show up in a #get request on some theme pages, and also on Portal's /#/portal/plans route.

Expected behavior: Tiers should not be returned by #get (or a filter should exist that prevents this) if Stripe is disconnected.
Probable workaround: Add logic check for whether stripe is connected before #get in theme code. (But Portal would still need to be patched.)

Steps to Reproduce

  1. Connect to stripe (test mode OK)
  2. Create some tiers.
  3. Disconnect from Stripe
  4. Retrieve tiers with {{#get tiers filter="active:true+visibility:public"}} Observe that tiers are returned, which messes up any theme using a custom sign-up page.
  5. Try to delete or deactivate these tiers in the Admin portal to prevent the behavior in 4. Observe that these tiers do not display in the admin portal.

Ghost Version

Ghost Pro

Node.js Version

Ghost Pro

How did you install Ghost?

Ghost Pro

Database type

MySQL 8

Browser & OS version

No response

Relevant log / error output

No response

Code of Conduct

  • I agree to be friendly and polite to people in this repository
@github-actions github-actions bot added the needs:triage [triage] this needs to be triaged by the Ghost team label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:triage [triage] this needs to be triaged by the Ghost team
Projects
None yet
Development

No branches or pull requests

1 participant