Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Korean Romanization is Wrong #19907

Open
1 task done
anaclumos opened this issue Mar 22, 2024 · 3 comments
Open
1 task done

Korean Romanization is Wrong #19907

anaclumos opened this issue Mar 22, 2024 · 3 comments
Labels
affects:i18n P3

Comments

@anaclumos
Copy link
Sponsor Contributor

Issue Summary

ㅊ should be romanized to "ch", but it's romanized to "c"

Steps to Reproduce

  1. Create New Post
  2. Use "ㅊ" somewhere in the title
  3. Open right panel, look for the sluggified URL
  4. ㅊ should be romanized to "ch", but it's romanized to "c"

Ghost Version

Ghost(Pro)

Node.js Version

Ghost(Pro)

How did you install Ghost?

Ghost(Pro)

Database type

MySQL 5.7

Browser & OS version

No response

Relevant log / error output

No response

Code of Conduct

  • I agree to be friendly and polite to people in this repository
@anaclumos
Copy link
Sponsor Contributor Author

anaclumos commented Mar 22, 2024 •
edited

I am willing to fix the error (if we can pinpoint the source of error)

@github-actions github-actions bot added the needs:triage [triage] this needs to be triaged by the Ghost team label Mar 22, 2024
@anaclumos
Copy link
Sponsor Contributor Author

Also, why don't we just allow UTF-8 slugs?

@anaclumos
Copy link
Sponsor Contributor Author

https://github.com/TryGhost/SDK/blob/244a9625f2358d52fc095570ff2722a69554c9ea/packages/string/lib/slugify.js#L1

Seems like it's coming from here?

@anaclumos anaclumos mentioned this issue Mar 22, 2024
Open
@daniellockyer daniellockyer added the P3 label Mar 28, 2024 — with Linear
@daniellockyer daniellockyer removed the needs:triage [triage] this needs to be triaged by the Ghost team label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects:i18n P3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@daniellockyer @anaclumos @royalfig