Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nuxt): route announcer #25741

Merged
merged 86 commits into from Apr 17, 2024
Merged

feat(nuxt): route announcer #25741

merged 86 commits into from Apr 17, 2024

Conversation

ivan-kalachikov
Copy link
Contributor

@ivan-kalachikov ivan-kalachikov commented Feb 11, 2024 •
edited

🔗 Linked issue

14673

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolves #14673

Adding Route Announcer to Nuxt js for better accessibility.

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@stackblitz StackBlitz
Copy link

stackblitz bot commented Feb 11, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@ivan-kalachikov ivan-kalachikov marked this pull request as draft February 11, 2024 11:35
@ivan-kalachikov ivan-kalachikov changed the title feat(nuxt): route announcer - a11y feat(nuxt): route announcer Feb 12, 2024
@nuxt-studio Nuxt Studio
Copy link

nuxt-studio bot commented Feb 18, 2024

✅ Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio ↗︎ View Live Preview d42cd0c

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 17, 2024
View reviewed changes
test/nuxt/composables.test.ts Fixed Show fixed Hide fixed
test/nuxt/composables.test.ts Fixed Show fixed Hide fixed
@danielroe
Copy link
Member

Sorry for breaking the tests! 🙈

ivan-kalachikov and others added 21 commits April 12, 2024 22:14
@ivan-kalachikov
fix tests
5a3dde1
@ivan-kalachikov
Merge branch 'main' into feat/route-announcer
84186b1
@antfu @danielroe
docs: update the code style page (nuxt#26792)
1214488
@iiio2 @danielroe
chore: fix devcontainer.json syntax (nuxt#26776)
26a4d38
@huang-julien @danielroe
docs: reference correct composable in callWithNuxt (nuxt#26771)
5ae3d43
@renovate @danielroe
chore(deps): update devdependency @nuxt/test-utils to v3.12.1 (main) (n…
5c3d0f4 
…uxt#26793)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@mehdi-coding @danielroe
docs: add sample app.vue (nuxt#26796)
c6615b9
@shinGangan @danielroe
docs: remove direct link to subheading (nuxt#26775)
02f295f
@renovate @danielroe
chore(deps): update pnpm to v9 (main) (nuxt#26799)
b6c9779
@kawadah @danielroe
docs: fix srcDir description mentioning deprecated static/ direct…
275b08b 
…ory (nuxt#26804)
@edwinfadul @danielroe
docs: provide example of passing props to a child page (nuxt#26805)
372d578
@edwinfadul @danielroe
docs: provide example of exposing a pageRef from a child page (nuxt…
6531b95 
…#26806)
@renovate @danielroe
chore(deps): update all non-major dependencies (main) (nuxt#26768)
0f15567 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel Roe <daniel@roe.dev>
@danielroe
refactor: remove Politeness enum
763d6eb
@danielroe
chore: render span to avoid potential hydration errors
07f1ef1
@danielroe
chore: remove unused import
fb3e571
@danielroe
Merge remote-tracking branch 'origin/main' into feat/route-announcer
0f1d99c
@danielroe
Revert "fix tests"
b280fdc 
This reverts commit 5a3dde1.
@danielroe
Revert "fix tests"
7456115 
This reverts commit 262448a.
@danielroe
Revert "feat: add nuxt route announcer to default route-based app.vue"
754b751 
This reverts commit fdce83e.
@danielroe
test: remove .only
3c61f62
@danielroe
Copy link
Member

Looking into it, there seems to be an issue with having anything but a suspense node as root of app.vue when it comes to client-side components in current implementation. they are not being rendered by the time the server response is coming. it's not an issue introduced by this PR so I think we can go ahead and merge and investigate later.

cc: @huang-julien

@danielroe danielroe merged commit 4fea6da into nuxt:main Apr 17, 2024
37 of 38 checks passed
@danielroe
Copy link
Member

Thank you - this is fantastic! ❤️

@github-actions github-actions bot mentioned this pull request Apr 17, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harlan-zw harlan-zw harlan-zw left review comments

@lihbr lihbr lihbr left review comments

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
3.x enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Route accessibility announcer