Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(nuxt): move play online under installation #25978

Merged
merged 3 commits into from Apr 19, 2024

Conversation

moshetanzer
Copy link
Contributor

@moshetanzer moshetanzer commented Feb 27, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Hi,

Seems to be that play online should be under installation, since many users come back when installing a new Nuxt project and obviously want local install properly. Play online is cute, but IMHO not most important and note most used. Thus, i think installation guide should come first.
Another option is to put a little callout with a play online anchor

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

Copy link

stackblitz bot commented Feb 27, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

nuxt-studio bot commented Feb 27, 2024

βœ… Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio β†—οΈŽ View Live Preview 4cf3175

@moshetanzer moshetanzer changed the title docs(readme): move play online under installation docs(nuxt): move play online under installation Feb 27, 2024
@danielroe
Copy link
Member

I think the play online links are short enough that it makes sense to keep them at the top, particularly given it's the page linked to from 'Get Started' on homepage which is more generic than 'Installation'. Do you think they stop people from finding out how to install Nuxt?

What do you think @Atinux?

@moshetanzer
Copy link
Contributor Author

moshetanzer commented Feb 27, 2024 via email

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworded it slightly to make the purpose of this clearer, and added a link directly within the getting started introduction as well.

Thank you ❀️

@danielroe danielroe merged commit 525124b into nuxt:main Apr 19, 2024
5 of 6 checks passed
@github-actions github-actions bot mentioned this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants