feat: add useLink to NuxtLink
#26522
Conversation
|
|
|
We need to move the second test to some fixture |
| @@ -207,43 +280,11 @@ export function defineNuxtLink (options: NuxtLinkOptions) { | |||
| required: false, | |||
| }, | |||
| }, | |||
| useLink: useNuxtLink, | |||
There was a problem hiding this comment.
This matches RouterLink behaviour (which exposes a 'bound' composable which other libraries, like vuetify, can use to create custom links): https://router.vuejs.org/guide/advanced/composition-api.html#useLink.
| @@ -120,6 +120,79 @@ export function defineNuxtLink (options: NuxtLinkOptions) { | |||
| return resolvedPath | |||
| } | |||
|
|
|||
| function useNuxtLink (props: NuxtLinkProps) { | |||
There was a problem hiding this comment.
Just FYI this logic has some legacy issues, see #25532
I wouldn't consider fixing them as part of this PR but it will likely be updated in the future.
There was a problem hiding this comment.
Exactly. ❤️ Just wanted to check that this implementation would be compatible with the tree-shaking/bundle size improvements you have in mind.
|
Looks good, nice job. Didn't sanity check all of the logic but if tests are passing it should be good 🤷 |
🔗 Linked issue
resolves #22169
❓ Type of change
📚 Description
Check title: I need to add a test and include
useLinktype📝 Checklist