Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Polishing: avoid react and react dom as dependencies for notification-center-vue #5214

Open
2 tasks done
foxted opened this issue Feb 20, 2024 · 1 comment
Open
2 tasks done
Labels

Comments

@foxted
Copy link

foxted commented Feb 20, 2024

πŸ“œ Description

When pulling notification-center-vue in a Vue/Nuxt project, the react and react-dom dependencies should be "devDependencies". notification-center seems to only have react and react-dom as devDependencies as well.

This also conflicts with other potential third-party packages that have react as a peer dependency (like @vercel/analytics, forcing the use of --legacy-peer-deps flag or the overrides property in package.json.

πŸ‘Ÿ Reproduction steps

  • Install notification-center-vue in any vue project with @vercel/analytics
  • Notice the mismatch in version

πŸ‘ Expected behavior

It should not have react and react-dom listed as dependencies, but maybe devDependencies or peerDepencencies instead.

πŸ“ƒ Provide any additional context for the Bug.

No response

πŸ‘€ Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

🏒 Have you read the Contributing Guidelines?

@foxted foxted added the polishing Created by Linear-GitHub Sync label Feb 20, 2024
@scopsy scopsy removed the polishing Created by Linear-GitHub Sync label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants