Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Bug Report: HeadlessService.fetchNotifications returns different totalCount than expected #5215

Open
2 tasks done
lwuethrich-devedis opened this issue Feb 20, 2024 · 2 comments
Labels

Comments

@lwuethrich-devedis
Copy link

馃摐 Description

I believe the HeadlessService.fetchNotifications returns as totalCountthe number of elements fetched and not the number of total elements.

馃憻 Reproduction steps

  1. Fetch notifications with the HeadlessService.fetchNotifications method, and pass a query limit of 1 -> totalCount= 1
    1. Fetch notifications with the HeadlessService.fetchNotifications method, and pass a different query limit -> totalCountis different (number of data returned)

馃憤 Expected behavior

I would expect that totalCount returns the count of all notifications and not only number of returned elements.

馃憥 Actual Behavior with Screenshots

It seems to return the count of the elements returned in the response.

Novu version

Novu SaaS

npm version

@novu/headless": "0.23.1"

node version

No response

馃搩 Provide any additional context for the Bug.

No response

馃憖 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find a similar issue

馃彚 Have you read the Contributing Guidelines?

Are you willing to submit PR?

None

Copy link

linear bot commented Feb 20, 2024

@lwuethrich-devedis lwuethrich-devedis changed the title 馃悰 Bug Report: HeadlessService.fetchNotifications returns wrong totalCount 馃悰 Bug Report: HeadlessService.fetchNotifications returns different totalCount than expected Feb 20, 2024
@Abobos
Copy link
Contributor

Abobos commented Apr 19, 2024

Can I work on this issue?
@scopsy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants