Select Topic Area

Bug

Body

The GraphQL addPullRequestReviewThread is the current non-deprecated way of adding comment threads.

It appears that it always associates a request to create a comment with the latest commit of the file. There is no commitOID (https://docs.github.com/en/graphql/reference/input-objects#addpullrequestreviewthreadinput) argument to specify which commit is referenced. You can tie the comment to a pull request review (via the pullRequestReviewId) and you can specify a commit ID for that pull request review, but that commit ID is ignored by this method.

There are two problems here:

1. It creates a race condition. Since there is no way to specify the commit, it's possible that even if you intend to add the comment to the latest commit, a new commit could be added by another user, and the line number given for the comment now references the new commit causing the comment to be placed at the wrong line.It's for this reason that I have marked this as a bug.
2. It makes it hard adding comments through the API when examining a specific commit as you can't add comments based off that commit. You can look for and handle the race condition, and do the line number delta calculation yourself, but it still wont' be correctly associated with the correct commit.