Allow PRs to "close" a discussion #20
Replies: 3 comments 7 replies
-
This would indeed be really useful, as we (Jellyfin) intend to use Discussions as a way to brainstorm features and involved the community at large in the design process. As such, the current plan would be to use one discussion per feature and, ideally, we'd have a way to mark said discussion as "resolved" or "completed" through a commit or a PR, making it easy for users to see which discussion is over. |
Beta Was this translation helpful? Give feedback.
-
@becca Hi! Can you give an initial comment, e.g. if this is tracked internally or questions are still open/to be discussed. As I'm not sure what 👀 means :) Appreciate any feedback, thanks! |
Beta Was this translation helpful? Give feedback.
-
+1, would also be helpful to allow commits to close a discussion, just like issues |
Beta Was this translation helpful? Give feedback.
-
Why
By moving feature requests to Discussions we've lost the ability to include a
closes #XXXX
in the PR description that automatically closes the feature request(s). This (and the feature that#XXXX
automatically creates a link in the issue) removes some important paper trail for e.g. finding the culprit to a regression.How
Beta Was this translation helpful? Give feedback.
All reactions