@dipree This looks really great! Two bugs I noticed immediately when submitting a PR review:

1. When toggling preview the review box changes size.
2. The review box doesn't stay in place as I scroll. It sometimes appears to recalculate, but lags behind, so I lose the box quite easily.

I also sort of miss the file attachment banner that used to be at the bottom of the comment box. Is there a keyboard shortcut to quickly open the attach file system dialog instead of using the "Attach files" button in the toolbar?

Looks pretty nice, although the background around the comment box being the same color as the rest of the page makes it a little hard to tell where the text box is.

In the old comment box, you could switch from Write to Preview and back to Write, and undo would work. Now undo doesn't work in that scenario.

This new input box is almost very hard for me to see.
First i thought some css / js had failed to load, and that all input boxes now were in a semi broken state.

I can no longer see at a glance that something is a text input box, the "comment on PR"-box is now even styled the same as the "view deployments" button, but only one of these two are an input box. See attached image.

I'm unsure of the motivation for this change, but it seems like change for the reason of keeping the internal design team busy and employed, and not for making input fields more accessible as claimed by the blog post announcing the change.

I'm of a mind with several others who have highlighted issues indexing on and tracking the text input field. Especially when having to cycle through multiple tabs, windows, or workspaces. The change in context in such cases makes it much harder to acquire and engage with for me. This was alleviated somewhat by using high contrast themes, but at a significant cost of increased fatigue when using the rest of the UI.

The use of a small frame around the comments box, like the one still used when replying in-thread, might alleviate this.

Beyond the general issue of indexing on the field, I also feel there is an insufficient differentiation between text-input and preview modes. Several times while typing this comment, I moved between other tabs to make sure I wasn't forgetting any specific issues I'd had thus far. On returning, I began typing only to realize I was still previewing my comment.

This might be alleviated by either more actively highlighting the "Write" and "Preview" tabs, or by changing the colour of the background between the two. I incline to the former option, like so:

Write Mockup:

Preview Mockup:

Obviously, not quite like that, but a variation on that conceptual theme.

Edit:
To an extent, my suggestions are already present:

When an in-thread comment box isn't actively focused, the un-selected tab matches the colour of the surrounding frame, and the active tab matches the text field. This helps me to understand which feature is active more quickly. This frame also helps highlight the comment box generally.

Bug report with miss preview tab update

1. Prepare comment with screenshot and switch to preview tab;
2. Post it;
3. Bug: it will keep preview tab with your content instead clean it;
4. If you switch to write tab again then all will be updated.

Since the editor was changed a few days ago, the display of an issue on a cell phone is no longer correct in the mobile view.

Open an issue, for example this one:

sabbelasichon/typo3-rector#3828

If you scroll down a little, you will briefly see that the editor icons are very wide and then disappear.

The issue is then displayed correctly.

Additionally the ... menu doesn't work at all on Google Chrome mobile and instead i jump to the start of the page. The jump to top can even be reproduced on desktop with F12 and the mobile view

PS: I liked the editor before more.

There are two issues I've run into. One's a visual bug, the other is a drop in accessibility for keyboard users:

Dropdowns are occluded

The pane now occludes dropdowns, like this:

Buttons no longer findable with keyboard drivers

The contents of the pane used to be searchable by keyboard-driven plugins like Vimium. As in I could trigger a click on Review changes, press F again and it would find the textbox inside for me to focus into. Now, it doesn't work anymore.

The UI might be “prettier” but the lack of a frame/border for the actual textarea removed a ux affordance and made it harder to distinguish what is happening or intended to happen. People understand intuitively what a textarea looks like and that it is meant to accept input. The new UI doesn’t convey that info and it looks like you would be clocking into and typing into “the void” across all platforms (Chrome and Firefox on Windows, Firefox on Linux, Safari on iOS). IIRC there is no caret showing the readiness to accept input and there is no hint given that the textarea is any different from the (ample) white space padding that surrounds it.

This is a step backwards! I appreciate the attempt but highly disagree with the move and consider at least this part of the change to be user hostile!

Issue forms have the new box now! But the placeholder "Leave a comment" overlaps with the placeholder on the form's textarea.