Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request][Compiler-v2] Improve performance of field mutable borrow check #12605

Open
rahxephon89 opened this issue Mar 20, 2024 · 0 comments
Open

[Feature Request][Compiler-v2] Improve performance of field mutable borrow check #12605

rahxephon89 opened this issue Mar 20, 2024 · 0 comments
Labels
compiler-v2 enhancement New feature or request stale-exempt Prevents issues from being automatically marked and closed as stale

Comments

@rahxephon89
Copy link
Contributor

馃殌 Feature Request

Motivation

In PR #12470, we visit the entire tree again after post_process_body to check whether there is borrow of a field mutably from an immutable ref. Instead of doing this, we need a custom visitor trait implementation to check this property as we ascent after the new exp is constructed.
@rahxephon89 rahxephon89 added enhancement New feature or request compiler-v2 labels Mar 20, 2024
@sausagee sausagee added the stale-exempt Prevents issues from being automatically marked and closed as stale label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler-v2 enhancement New feature or request stale-exempt Prevents issues from being automatically marked and closed as stale
Projects
Move Language and Runtime
Status: 馃搵 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sausagee @rahxephon89