Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Avoid using unicode in aptos-core, to reduce chances of bugs in IDEs #12671

Open
brmataptos opened this issue Mar 25, 2024 · 1 comment 路 May be fixed by #12687
Open

[Feature Request] Avoid using unicode in aptos-core, to reduce chances of bugs in IDEs #12671

brmataptos opened this issue Mar 25, 2024 · 1 comment 路 May be fixed by #12687
Assignees
Labels
enhancement New feature or request stale-exempt Prevents issues from being automatically marked and closed as stale

Comments

@brmataptos
Copy link
Contributor

馃殌 Feature Request

A few Rust IDE combinations seem to have issues with Unicode, notably Emacs with rust-analyzer. There was a recent fix to rust-analyzer, so maybe the "master" branch of rust-analyzer will solve the problem for me, but I wonder how many outside people would give up on our project if their editor froze as often as mine does.

Do we really need to use a UTF8 character to represent "(C)" in (many of) our source files? That's the only non-ASCII character in almost all files (2482 out of 3090 files). Just 10 files use non-ASCII characters for other things, mostly for ASCII art, ironically.

We should minimize use of non-ASCII in our source code.

@brmataptos brmataptos added the enhancement New feature or request label Mar 25, 2024
@brmataptos brmataptos self-assigned this Mar 25, 2024
@brmataptos
Copy link
Contributor Author

Note that Peter Nadimi has signed off on changing from 漏 to (c) in our copyright notices.

@brmataptos brmataptos linked a pull request Mar 26, 2024 that will close this issue
21 tasks
@brmataptos brmataptos added the stale-exempt Prevents issues from being automatically marked and closed as stale label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale-exempt Prevents issues from being automatically marked and closed as stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant