Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validators broadcast order votes upon receiving proposal votes #12697

Closed
wants to merge 25 commits into from
Closed

Validators broadcast order votes upon receiving proposal votes #12697

wants to merge 25 commits into from

Conversation

vusirikala
Copy link
Contributor

@vusirikala vusirikala commented Mar 27, 2024 •
edited

Description

Upon receiving quorum certificate for a block, all the validators immediately broadcast order votes. When the validators receive 2f+1 order votes, they will execute the block. This will reduce the end to end latency as the validators don't have to wait for 2 chain rule to execute the block. We expect that this PR will reduce the end to end latency by 100ms.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@trunk-io Trunk.io
Copy link

trunk-io bot commented Mar 27, 2024 •
edited

⏱️ 24h 23m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-tests 4h 49m ⬜ ⬜ 🟥 🟥 🟥 (+8 more)
rust-unit-coverage 4h 33m 🟩 
rust-smoke-coverage 3h 53m 🟩 
adhoc-forge-test / forge 2h 54m 🟩 🟩 🟩 🟩 🟩 (+3 more)
rust-images / rust-all 2h 46m 🟩 🟩 🟥 🟩 🟩 (+7 more)
run-tests-main-branch 1h 47m 🟩 🟩 🟩 🟩 🟩 (+16 more)
rust-lints 1h 17m 🟩 🟩 🟥 🟩 🟥 (+8 more)
windows-build 56m 🟩 🟩 🟩 
general-lints 27m 🟩 🟩 🟩 🟩 🟩 (+8 more)
check-dynamic-deps 26m 🟩 🟩 🟩 🟩 🟩 (+9 more)
check 9m 🟩 ⬜ 🟩 
semgrep/ci 6m 🟩 🟩 🟩 🟩 🟩 (+9 more)
file_change_determinator 5m 🟩 🟩 🟩 🟩 🟩 (+17 more)
file_change_determinator 3m 🟩 🟩 🟩 🟩 🟩 (+8 more)
file_change_determinator 3m 🟩 🟩 🟩 🟩 🟩 (+9 more)
file_change_determinator 3m 🟩 🟩 🟩 🟩 🟩 (+7 more)
permission-check 1m 🟩 🟩 🟩 🟩 🟩 (+17 more)
permission-check 1m 🟩 🟩 🟩 🟩 🟩 (+17 more)
permission-check 1m 🟩 🟩 🟩 🟩 🟩 (+17 more)
permission-check 1m 🟩 🟩 🟩 🟩 🟩 (+17 more)
permission-check 42s 🟩 🟩 🟩 🟩 🟩 (+7 more)
rust-move-tests 41s 🟩 🟩 🟩 🟩 🟩 (+8 more)
determine-docker-build-metadata 24s 🟩 🟩 🟩 🟩 🟩 (+7 more)
determine-forge-run-metadata 16s 🟩 🟩 🟩 🟩 🟩 (+3 more)
upload-to-codecov 12s 🟩 

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-move-tests 3s 5m -99%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@vusirikala vusirikala marked this pull request as draft March 27, 2024 00:58
@vusirikala vusirikala added the CICD:build-images when this label is present github actions will start build+push rust images from the PR. label Mar 29, 2024
@vusirikala vusirikala changed the title [Draft] Validators broadcast order votes upon receiving proposal votes Validators broadcast order votes upon receiving proposal votes Mar 29, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 29, 2024 •
edited

Codecov Report

Attention: Patch coverage is 42.90221% with 181 lines in your changes are missing coverage. Please review.

Project coverage is 69.6%. Comparing base (36855e7) to head (924a71b).
Report is 9 commits behind head on main.

❗ Current head 924a71b differs from pull request most recent head 33017f8. Consider uploading reports for the commit 33017f8 to get more accurate results

Files Patch % Lines
consensus/src/pending_order_votes.rs 8.9% 61 Missing ⚠️
consensus/src/round_manager.rs 36.6% 45 Missing ⚠️
consensus/consensus-types/src/order_vote.rs 42.0% 40 Missing ⚠️
consensus/src/liveness/round_state.rs 39.1% 14 Missing ⚠️
consensus/safety-rules/src/serializer.rs 0.0% 13 Missing ⚠️
consensus/safety-rules/src/safety_rules_2chain.rs 87.5% 4 Missing ⚠️
consensus/src/metrics_safety_rules.rs 78.5% 3 Missing ⚠️
consensus/safety-rules/src/safety_rules.rs 87.5% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             main   #12697     +/-   ##
=========================================
- Coverage    69.8%    69.6%   -0.2%     
=========================================
  Files        2293     2295      +2     
  Lines      436088   436401    +313     
=========================================
- Hits       304431   303985    -446     
- Misses     131657   132416    +759

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vusirikala vusirikala closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sitalkedia sitalkedia Awaiting requested review from sitalkedia

@zekun000 zekun000 Awaiting requested review from zekun000 zekun000 is a code owner

@danielxiangzl danielxiangzl Awaiting requested review from danielxiangzl

@bchocho bchocho Awaiting requested review from bchocho

@gregnazario gregnazario Awaiting requested review from gregnazario gregnazario will be requested when the pull request is marked ready for review gregnazario is a code owner

@JoshLind JoshLind Awaiting requested review from JoshLind JoshLind will be requested when the pull request is marked ready for review JoshLind is a code owner

@sasha8 sasha8 Awaiting requested review from sasha8 sasha8 will be requested when the pull request is marked ready for review sasha8 is a code owner

@ibalajiarun ibalajiarun Awaiting requested review from ibalajiarun ibalajiarun will be requested when the pull request is marked ready for review ibalajiarun is a code owner

Assignees
No one assigned
Labels
CICD:build-images when this label is present github actions will start build+push rust images from the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@vusirikala