Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[not for review] Igor/test after fa migration same address #12715

Draft
wants to merge 1 commit into
base: igor/test_after_fa_migration
Choose a base branch
from
Draft

[not for review] Igor/test after fa migration same address #12715

wants to merge 1 commit into from

Conversation

igor-aptos
Copy link
Contributor

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@igor-aptos igor-aptos added the CICD:run-execution-performance-test Run execution performance test label Mar 27, 2024
@trunk-io Trunk.io
Copy link

trunk-io bot commented Mar 27, 2024 •
edited

⏱️ 56h 52m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-coverage 24h 🟥 🟥 
rust-unit-tests 20h 🟥 ⬜ 🟥 🟥 
rust-smoke-coverage 4h 59m 🟩 🟩 
windows-build 1h 57m 🟩 🟩 🟩 🟩 🟩 
execution-performance / single-node-performance 1h 29m 🟥 🟥 🟥 🟥 🟥 
rust-move-tests 1h 25m 🟥 🟥 🟩 
rust-move-unit-coverage 1h 2m 🟩 🟩 🟩 
rust-images / rust-all 36m 🟩 🟥 🟥 🟩 
run-tests-main-branch 23m 🟥 🟥 🟥 🟩 
rust-lints 21m 🟩 🟥 🟥 🟥 
check 17m 🟩 🟩 🟩 🟩 
general-lints 9m 🟩 🟩 🟩 🟩 
check-dynamic-deps 9m 🟩 🟩 🟩 🟩 🟩 
semgrep/ci 2m 🟩 🟩 🟩 🟩 🟩 
execution-performance / file_change_determinator 55s 🟩 🟩 🟩 🟩 🟩 
file_change_determinator 49s 🟩 🟩 🟩 🟩 
file_change_determinator 47s 🟩 🟩 🟩 🟩 
file_change_determinator 43s ⬜ 🟩 🟩 🟩 🟩 
permission-check 12s ⬜ 🟩 🟩 🟩 🟩 
file_change_determinator 12s 🟩 
permission-check 12s 🟩 🟩 🟩 🟩 🟩 
permission-check 11s ⬜ 🟩 🟩 🟩 🟩 
permission-check 11s 🟩 🟩 🟩 🟩 
permission-check 11s 🟩 🟩 🟩 🟩 
determine-docker-build-metadata 9s 🟩 🟩 🟩 🟩 

🚨 3 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-unit-tests 6h 27m +1225%
execution-performance / single-node-performance 35m 23m +51%
windows-build 24m 20m +24%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@igor-aptos igor-aptos marked this pull request as draft March 27, 2024 23:05
@codecov Codecov
Copy link

codecov bot commented Mar 27, 2024 •
edited

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 64.2%. Comparing base (8f48269) to head (a640a2e).

Files Patch % Lines
...pes/src/account_config/resources/fungible_store.rs 0.0% 5 Missing ⚠️
Additional details and impacted files 
@@                       Coverage Diff                       @@
##           igor/test_after_fa_migration   #12715     +/-   ##
===============================================================
+ Coverage                          64.1%    64.2%   +0.1%     
===============================================================
  Files                               820      820             
  Lines                            183194   183195      +1     
===============================================================
+ Hits                             117437   117679    +242     
+ Misses                            65757    65516    -241

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@igor-aptos igor-aptos force-pushed the igor/test_after_fa_migration_same_address branch from 45a45dc to 29f38e4 Compare March 29, 2024 05:18
@igor-aptos igor-aptos added the CICD:run-execution-performance-full-test Run execution performance test (full version) label Mar 29, 2024
@igor-aptos igor-aptos force-pushed the igor/test_after_fa_migration_same_address branch from 29f38e4 to a640a2e Compare March 29, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msmouse msmouse Awaiting requested review from msmouse msmouse will be requested when the pull request is marked ready for review msmouse is a code owner

@lightmark lightmark Awaiting requested review from lightmark lightmark will be requested when the pull request is marked ready for review lightmark is a code owner

@grao1991 grao1991 Awaiting requested review from grao1991 grao1991 will be requested when the pull request is marked ready for review grao1991 is a code owner

@davidiw davidiw Awaiting requested review from davidiw davidiw will be requested when the pull request is marked ready for review davidiw is a code owner

@movekevin movekevin Awaiting requested review from movekevin movekevin will be requested when the pull request is marked ready for review movekevin is a code owner

@wrwg wrwg Awaiting requested review from wrwg wrwg will be requested when the pull request is marked ready for review wrwg is a code owner

Assignees
No one assigned
Labels
CICD:run-execution-performance-full-test Run execution performance test (full version) CICD:run-execution-performance-test Run execution performance test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@igor-aptos