Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI/CD] Delay windows CLI and protos test until appropriate event. #12716

Merged
merged 1 commit into from Mar 29, 2024
Merged

[CI/CD] Delay windows CLI and protos test until appropriate event. #12716

merged 1 commit into from Mar 29, 2024

Conversation

JoshLind
Copy link
Contributor

@JoshLind JoshLind commented Mar 27, 2024 •
edited

Description

This PR:

  1. Delays the: (i) windows CLI GHA job; and (ii) the check protos job, to only run on each PR when an appropriate event occurs. This includes: (i) when auto-merge is enabled; or (ii) when the correct label is added to the PR. This should help reduce the number of unnecessary/redundant runs of the job on each PR.
  2. Fixes a missing step in rust-build-cached-packages.

Testing Plan

Manual verification and existing test infrastructure.

@trunk-io Trunk.io
Copy link

trunk-io bot commented Mar 27, 2024 •
edited

⏱️ 6h 41m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-tests 1h 44m 🟥 🟩 ⬜ ⬜ 🟩 (+1 more)
rust-lints 41m 🟩 🟩 ⬜ 🟩 🟩 (+1 more)
rust-smoke-tests 38m 🟩 
rust-unit-coverage 29m ⬜ 
rust-smoke-coverage 29m ⬜ 
run-tests-main-branch 26m 🟩 🟩 🟩 🟩 🟩 (+1 more)
execution-performance / single-node-performance 21m 🟩 
check-dynamic-deps 15m 🟩 🟩 🟩 🟩 🟩 (+1 more)
forge-compat-test / forge 14m 🟩 
forge-e2e-test / forge 14m 🟩 
rust-move-tests 14m 🟩 🟩 🟩 🟩 🟩 (+1 more)
rust-images / rust-all 14m 🟩 
general-lints 12m 🟩 🟩 🟩 🟩 🟩 (+1 more)
check 12m 🟩 🟩 🟩 
cli-e2e-tests / run-cli-tests 7m 🟩 
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose 3m 🟩 
semgrep/ci 2m 🟩 🟩 🟩 🟩 🟩 (+1 more)
file_change_determinator 1m 🟩 🟩 🟩 🟩 🟩 (+1 more)
file_change_determinator 1m 🟩 🟩 🟩 🟩 🟩 (+1 more)
file_change_determinator 1m 🟩 🟩 🟩 🟩 🟩 
node-api-compatibility-tests / node-api-compatibility-tests 50s 🟩 
permission-check 21s 🟩 🟩 🟩 🟩 🟩 
permission-check 21s 🟩 🟩 🟩 🟩 🟩 (+1 more)
permission-check 19s 🟩 🟩 🟩 🟩 🟩 (+1 more)
permission-check 16s 🟩 🟩 🟩 🟩 🟩 
execution-performance / file_change_determinator 15s 🟩 
file_change_determinator 11s 🟩 
permission-check 2s 🟩 
determine-docker-build-metadata 1s 🟩 

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-lints 6m 7m -25%
rust-move-tests 3s 9m -99%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@JoshLind JoshLind marked this pull request as ready for review March 28, 2024 13:18
@JoshLind JoshLind requested review from a team as code owners March 28, 2024 13:18
@JoshLind JoshLind changed the title [CI/CD] Delay windows CLI test until appropriate event. [CI/CD] Delay windows CLI and protos test until appropriate event. Mar 28, 2024
@JoshLind JoshLind added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Mar 29, 2024
@JoshLind JoshLind requested a review from aluon March 29, 2024 19:00
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on b09489299e38d731cf7561abc19949490d1dcbf7

two traffics test: inner traffic : committed: 8148 txn/s, latency: 4804 ms, (p50: 4500 ms, p90: 5700 ms, p99: 10100 ms), latency samples: 3519940
two traffics test : committed: 100 txn/s, latency: 1909 ms, (p50: 1800 ms, p90: 2100 ms, p99: 7000 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.224, avg: 0.204", "QsPosToProposal: max: 0.255, avg: 0.241", "ConsensusProposalToOrdered: max: 0.468, avg: 0.414", "ConsensusOrderedToCommit: max: 0.319, avg: 0.301", "ConsensusProposalToCommit: max: 0.735, avg: 0.715"]
Max round gap was 1 [limit 4] at version 1713455. Max no progress secs was 5.061065 [limit 15] at version 1713455.
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.9.5 ==> b09489299e38d731cf7561abc19949490d1dcbf7

Compatibility test results for aptos-node-v1.9.5 ==> b09489299e38d731cf7561abc19949490d1dcbf7 (PR)
1. Check liveness of validators at old version: aptos-node-v1.9.5
compatibility::simple-validator-upgrade::liveness-check : committed: 6215 txn/s, latency: 5012 ms, (p50: 4800 ms, p90: 9000 ms, p99: 10200 ms), latency samples: 242420
2. Upgrading first Validator to new version: b09489299e38d731cf7561abc19949490d1dcbf7
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 676 txn/s, latency: 35045 ms, (p50: 35500 ms, p90: 55400 ms, p99: 57900 ms), latency samples: 56840
3. Upgrading rest of first batch to new version: b09489299e38d731cf7561abc19949490d1dcbf7
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 476 txn/s, submitted: 760 txn/s, expired: 283 txn/s, latency: 25025 ms, (p50: 26200 ms, p90: 46900 ms, p99: 52400 ms), latency samples: 36232
4. upgrading second batch to new version: b09489299e38d731cf7561abc19949490d1dcbf7
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2408 txn/s, latency: 12847 ms, (p50: 13100 ms, p90: 19500 ms, p99: 19800 ms), latency samples: 118020
5. check swarm health
Compatibility test for aptos-node-v1.9.5 ==> b09489299e38d731cf7561abc19949490d1dcbf7 passed
Test Ok

@JoshLind JoshLind merged commit d4872b2 into main Mar 29, 2024
101 of 105 checks passed
@JoshLind JoshLind deleted the windows_cli_build_delay branch March 29, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aluon aluon aluon approved these changes

@gregnazario gregnazario Awaiting requested review from gregnazario

@banool banool Awaiting requested review from banool

@rustielin rustielin Awaiting requested review from rustielin

Assignees
No one assigned
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JoshLind @aluon