Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forge] Switch Forge to the multi-region Docker repository #12719

Merged
merged 3 commits into from Mar 28, 2024

Conversation

sionescu
Copy link
Contributor

Description

Cherry-pick Forge and Docker build changes from main: push Docker images only to the newer multi-region repository.

sionescu and others added 3 commits March 27, 2024 20:10
We currently dont check that the tag and the aptos-node cargo.toml version match

This ensures that before publish we have to check the tag and version match only for release images

Test Plan: wrote unittests and added a testing workflow

made the script possibel to unittest
Reference GCP_DOCKER_ARTIFACT_REPO as configuration variable for
better debuggability.
@sionescu sionescu requested review from a team and JoshLind as code owners March 28, 2024 00:11
Copy link

trunk-io bot commented Mar 28, 2024

⏱️ 1h 35m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-tests 37m 🟩
windows-build 31m 🟩
rust-lints 9m 🟩
run-tests-main-branch 6m 🟥
check 4m 🟩
general-lints 3m 🟩
check-dynamic-deps 2m 🟩
semgrep/ci 46s 🟩
file_change_determinator 25s 🟩
test-copy-images 19s 🟩
file_change_determinator 12s 🟩
permission-check 3s 🟩
permission-check 3s 🟩
permission-check 3s 🟩
permission-check 2s 🟩

🚨 4 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
run-tests-main-branch 6m 4m +55%
windows-build 31m 20m +54%
rust-unit-tests 37m 27m +40%
rust-lints 9m 7m +21%

settingsfeedbackdocs ⋅ learn more about trunk.io

@sionescu sionescu merged commit 63829cf into testnet Mar 28, 2024
49 of 50 checks passed
@sionescu sionescu deleted the stelian/testnet-docker-build branch March 28, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants