Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the proto breaking check. #12713

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add the proto breaking check. #12713

wants to merge 4 commits into from
+22 −0

Conversation

larry-aptos
Copy link
Contributor

@larry-aptos larry-aptos commented Mar 27, 2024 •
edited

Description

  • Add a script that can check compatibility of the protobuf used downstream against the aptos-core.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify) GRPC protobuf

How Has This Been Tested?

Locally tested; looks good.

image

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@trunk-io Trunk.io
Copy link

trunk-io bot commented Mar 27, 2024 •
edited

⏱️ 8h 27m total CI duration on this PR
Job Cumulative Duration Recent Runs
windows-build 3h 48m 🟩 🟩 🟩 🟩 🟩 (+6 more)
rust-unit-tests 1h 11m ⬜ ⬜ ⬜ ⬜ 🟩 (+5 more)
run-tests-main-branch 47m 🟩 🟩 🟩 🟩 🟩 (+6 more)
rust-lints 46m ⬜ ⬜ ⬜ 🟩 🟩 (+5 more)
check 34m 🟥 ⬜ ⬜ 🟥 🟥 (+6 more)
rust-move-tests 25m 🟩 🟩 🟩 🟩 🟩 (+5 more)
check-dynamic-deps 23m 🟩 🟩 🟩 🟩 🟩 (+6 more)
general-lints 20m 🟩 🟩 ⬜ 🟩 🟩 (+5 more)
semgrep/ci 6m 🟩 🟩 🟩 🟩 🟩 (+6 more)
file_change_determinator 2m 🟩 🟩 🟩 🟩 🟩 (+6 more)
file_change_determinator 2m 🟩 🟩 🟩 🟩 🟩 (+5 more)
file_change_determinator 2m 🟩 🟩 🟩 🟩 🟩 (+2 more)
permission-check 27s 🟩 🟩 🟩 🟩 🟩 (+4 more)
permission-check 25s 🟩 🟩 🟩 🟩 🟩 (+5 more)
permission-check 25s 🟩 🟩 🟩 🟩 🟩 (+5 more)
permission-check 24s 🟩 🟩 🟩 🟩 🟩 (+4 more)

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
check-dynamic-deps 3m 2m +53%
rust-move-tests 4s 12m -99%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@larry-aptos larry-aptos requested a review from a team March 27, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@larry-aptos