[CI/CD] Integrate cargo-machete to remove unused deps. #12724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12724 +/- ##
=========================================
- Coverage 62.6% 62.6% -0.1%
=========================================
Files 819 819
Lines 183454 183542 +88
=========================================
- Hits 115015 115009 -6
- Misses 68439 68533 +94 ☔ View full report in Codecov by Sentry. |
9667b1a
to
b980f05
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2c61c8a
to
e01c419
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
brianolson
approved these changes
Apr 2, 2024
sionescu
approved these changes
Apr 2, 2024
GotenJBZ
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates cargo-machete into our CI/CD pipeline to detect unused dependencies. The detection step is added to the linter workflow and will fail when unused dependencies are added.
To ensure this passes, I've gone through and removed all unused dependencies as reported by
cargo-machete. Exceptions have been added in some cases to account for false positives (thankfully, these are not super common).Note: it does look like this PR has reduced compilation times on various CI/CD jobs and tests, but we'll need to see enough runs to quantify/trust it.
Testing Plan
Manual verification and existing test infrastructure.
Note:
main, so it doesn't look like anything new in CI/CD has been broken.