Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

randomnesss spec fix (by @rahxephon89) #12721

Closed
wants to merge 3 commits into from
Closed

randomnesss spec fix (by @rahxephon89) #12721

wants to merge 3 commits into from

Conversation

zjma
Copy link
Contributor

@zjma zjma commented Mar 28, 2024

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@trunk-io Trunk.io
Copy link

trunk-io bot commented Mar 28, 2024 •
edited

⏱️ 35h 32m total CI duration on this PR
Job Cumulative Duration Recent Runs
prover-inconsistency-test 28h 16m 🟥 🟥 🟥 🟥 🟩 (+5 more)
rust-unit-tests 2h 39m 🟩 🟩 🟩 🟩 🟩 (+2 more)
rust-move-unit-coverage 1h 51m 🟩 🟩 🟩 🟩 🟩 (+1 more)
rust-lints 43m 🟩 🟩 🟩 🟩 🟩 (+1 more)
windows-build 43m 🟩 🟩 
run-tests-main-branch 25m 🟩 🟩 🟩 🟩 🟩 (+1 more)
rust-move-tests 14m 🟩 🟩 🟩 🟩 🟩 (+1 more)
check-dynamic-deps 13m 🟩 🟩 🟩 🟩 🟩 (+1 more)
general-lints 12m 🟩 🟩 🟩 🟩 🟩 (+1 more)
check 8m 🟩 🟩 
semgrep/ci 2m 🟩 🟩 🟩 🟩 🟩 (+1 more)
file_change_determinator 1m 🟩 🟩 🟩 🟩 🟩 (+1 more)
file_change_determinator 1m 🟩 🟩 🟩 🟩 🟩 (+1 more)
file_change_determinator 1m 🟩 🟩 🟩 🟩 🟩 
permission-check 21s 🟩 🟩 🟩 🟩 🟩 (+1 more)
permission-check 20s 🟩 🟩 🟩 🟩 🟩 (+1 more)
permission-check 15s 🟩 🟩 🟩 🟩 🟩 (+1 more)
permission-check 14s 🟩 🟩 🟩 🟩 🟩 (+1 more)

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-lints 5m 7m -29%
rust-move-tests 3s 6m -99%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@zjma zjma changed the title randomnesss spec fix randomnesss spec fix (by @rahxephon89) Mar 28, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 28, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.6%. Comparing base (3eb19c4) to head (d7b63b8).

Additional details and impacted files 
@@             Coverage Diff             @@
##             main   #12721       +/-   ##
===========================================
- Coverage    69.2%    62.6%     -6.6%     
===========================================
  Files        2293      819     -1474     
  Lines      436530   183542   -252988     
===========================================
- Hits       302317   115009   -187308     
+ Misses     134213    68533    -65680

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rahxephon89 rahxephon89 marked this pull request as ready for review March 31, 2024 23:30
@rahxephon89 rahxephon89 closed this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahxephon89 rahxephon89 rahxephon89 approved these changes

@junkil-park junkil-park Awaiting requested review from junkil-park junkil-park is a code owner

@davidiw davidiw Awaiting requested review from davidiw davidiw is a code owner

@movekevin movekevin Awaiting requested review from movekevin movekevin is a code owner

@wrwg wrwg Awaiting requested review from wrwg wrwg is a code owner

@zekun000 zekun000 Awaiting requested review from zekun000

@danielxiangzl danielxiangzl Awaiting requested review from danielxiangzl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zjma @rahxephon89