Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extra base image fix #13081

Merged
merged 1 commit into from Apr 27, 2024
Merged

extra base image fix #13081

merged 1 commit into from Apr 27, 2024

Conversation

zjma
Copy link
Contributor

@zjma zjma commented Apr 27, 2024

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@trunk-io Trunk.io
Copy link

trunk-io bot commented Apr 27, 2024 •
edited

⏱️ 23m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-lints 6m 🟩 
rust-move-tests 4m 🟩 
run-tests-main-branch 4m 🟩 
rust-targeted-unit-tests 3m 🟩 
general-lints 2m 🟩 
determine-test-metadata 2m 🟩 
check-dynamic-deps 1m 🟩 
semgrep/ci 24s 🟩 
file_change_determinator 12s 🟩 
file_change_determinator 9s 🟩 
permission-check 6s 🟩 
permission-check 4s 🟩 
permission-check 3s 🟩 
permission-check 2s 🟩 

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-move-tests 4m 9m -53%
rust-targeted-unit-tests 3m 17m -83%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

perryjrandall
perryjrandall approved these changes Apr 27, 2024
View reviewed changes
Copy link
Contributor

@perryjrandall perryjrandall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sheepit

@perryjrandall perryjrandall marked this pull request as ready for review April 27, 2024 00:18
@perryjrandall perryjrandall requested a review from a team as a code owner April 27, 2024 00:18
@perryjrandall perryjrandall merged commit 6417755 into main Apr 27, 2024
65 checks passed
@perryjrandall perryjrandall deleted the zjma/extra-base-image-fix branch April 27, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perryjrandall perryjrandall perryjrandall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zjma @perryjrandall