Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

models.device.getOsVersion - Do not append variant for unified OS versions #1318

Open
mtoman opened this issue Mar 28, 2023 · 2 comments
Open

models.device.getOsVersion - Do not append variant for unified OS versions #1318

mtoman opened this issue Mar 28, 2023 · 2 comments

Comments

@mtoman
Copy link

mtoman commented Mar 28, 2023

We removed the variant from the OS version string since meta-balena 2.85.0, however the change was not picked by all device types immediately so it is not safe to assume if version > 2.85.0: do_not_append_variant. We could maybe check that the built OS version string is valid before returning it.

Expected Behavior

models.device.getOsVersion does not append the variant if the actual OS version string does not include it.

Actual Behavior

The variant is appended blindly and returns e.g. 2.95.8+prod even though the actual OS version is 2.95.8.

Steps to Reproduce the Problem

  1. Provision a RPi4 with balenaOS 2.95.8
  2. balena.models.device.getOsVersion(uuid) returns 2.95.8+prod

Specifications

  • SDK version: 16.38.0
@jellyfish-bot
Copy link

[mtoman] This has attached https://jel.ly.fish/9d88a5dc-b534-485a-a720-9049085abaf4

@thgreasi
Copy link
Member

@mtoman is 2.85.0 the first w/o a dev/prod for all DTs?
Also, is there any such magic version for ESRs as well, that is also consistent across all DTs?
The most appropriate way I can think atm is to actually make an async call to the API to figure out whether that version is a unified release or not 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thgreasi @mtoman @jellyfish-bot